Commit 525ba62c authored by Andrey Smirnov's avatar Andrey Smirnov Committed by Greg Kroah-Hartman
Browse files

serdev: Introduce devm_serdev_device_open() 



Add code implementing managed version of serdev_device_open() for
serdev device drivers that "open" the device during driver's lifecycle
only once (e.g. opened in .probe() and closed in .remove()).

Cc: linux-kernel@vger.kernel.org
Cc: linux-serial@vger.kernel.org
Cc: Rob Herring <robh@kernel.org>
Cc: cphealy@gmail.com
Cc: Guenter Roeck <linux@roeck-us.net>
Cc: Lucas Stach <l.stach@pengutronix.de>
Cc: Nikita Yushchenko <nikita.yoush@cogentembedded.com>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Pavel Machek <pavel@ucw.cz>
Cc: Andy Shevchenko <andy.shevchenko@gmail.com>
Cc: Johan Hovold <johan@kernel.org>
Cc: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
Acked-by: default avatarRob Herring <robh@kernel.org>
Reviewed-by: default avatarSebastian Reichel <sebastian.reichel@collabora.co.uk>
Reviewed-by: default avatarGuenter Roeck <linux@roeck-us.net>
Signed-off-by: default avatarAndrey Smirnov <andrew.smirnov@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 98869f9f

Documentation/driver-model/devres.txt

+3 −0
Original line number Diff line number Diff line
@@ -384,6 +384,9 @@ RESET 
  devm_reset_control_get()

  devm_reset_controller_register()



SERDEV

  devm_serdev_device_open()



SLAVE DMA ENGINE

  devm_acpi_dma_controller_register()

drivers/tty/serdev/core.c

+27 −0
Original line number Diff line number Diff line
@@ -132,6 +132,33 @@ void serdev_device_close(struct serdev_device *serdev) 
}

EXPORT_SYMBOL_GPL(serdev_device_close);



static void devm_serdev_device_release(struct device *dev, void *dr)

{

	serdev_device_close(*(struct serdev_device **)dr);

}



int devm_serdev_device_open(struct device *dev, struct serdev_device *serdev)

{

	struct serdev_device **dr;

	int ret;



	dr = devres_alloc(devm_serdev_device_release, sizeof(*dr), GFP_KERNEL);

	if (!dr)

		return -ENOMEM;



	ret = serdev_device_open(serdev);

	if (ret) {

		devres_free(dr);

		return ret;

	}



	*dr = serdev;

	devres_add(dev, dr);



	return 0;

}

EXPORT_SYMBOL_GPL(devm_serdev_device_open);



void serdev_device_write_wakeup(struct serdev_device *serdev)

{

	complete(&serdev->write_comp);

include/linux/serdev.h

+1 −0
Original line number Diff line number Diff line
@@ -193,6 +193,7 @@ static inline int serdev_controller_receive_buf(struct serdev_controller *ctrl, 


int serdev_device_open(struct serdev_device *);

void serdev_device_close(struct serdev_device *);

int devm_serdev_device_open(struct device *, struct serdev_device *);

unsigned int serdev_device_set_baudrate(struct serdev_device *, unsigned int);

void serdev_device_set_flow_control(struct serdev_device *, bool);

int serdev_device_write_buf(struct serdev_device *, const unsigned char *, size_t);

CRA Git | Maintained and supported by SUSTech CRA and CCSE