Commit 525aaf9b authored by Ira Weiny's avatar Ira Weiny Committed by Linus Torvalds
Browse files

arch/kmap: remove redundant arch specific kmaps 



The kmap code for all the architectures is almost 100% identical.

Lift the common code to the core.  Use ARCH_HAS_KMAP_FLUSH_TLB to indicate
if an arch defines kmap_flush_tlb() and call if if needed.

This also has the benefit of changing kmap() on a number of architectures
to be an inline call rather than an actual function.

Signed-off-by: default avatarIra Weiny <ira.weiny@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Reviewed-by: default avatarChristoph Hellwig <hch@lst.de>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Christian König <christian.koenig@amd.com>
Cc: Chris Zankel <chris@zankel.net>
Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Helge Deller <deller@gmx.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: "James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>
Cc: Max Filippov <jcmvbkbc@gmail.com>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/20200507150004.1423069-4-ira.weiny@intel.com


Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 21596872

arch/arc/include/asm/highmem.h

+0 −2
Original line number Diff line number Diff line
@@ -30,8 +30,6 @@ 


#include <asm/cacheflush.h>



extern void *kmap(struct page *page);

extern void *kmap_high(struct page *page);

extern void *kmap_atomic(struct page *page);

extern void __kunmap_atomic(void *kvaddr);

extern void kunmap_high(struct page *page);

arch/arc/mm/highmem.c

+0 −10
Original line number Diff line number Diff line
@@ -49,16 +49,6 @@ 
extern pte_t * pkmap_page_table;

static pte_t * fixmap_page_table;



void *kmap(struct page *page)

{

	might_sleep();

	if (!PageHighMem(page))

		return page_address(page);



	return kmap_high(page);

}

EXPORT_SYMBOL(kmap);



void *kmap_atomic(struct page *page)

{

	int idx, cpu_idx;

arch/arm/include/asm/highmem.h

+0 −2
Original line number Diff line number Diff line
@@ -20,7 +20,6 @@ 


extern pte_t *pkmap_page_table;



extern void *kmap_high(struct page *page);

extern void kunmap_high(struct page *page);



/*
@@ -63,7 +62,6 @@ static inline void *kmap_high_get(struct page *page) 
 * when CONFIG_HIGHMEM is not set.

 */

#ifdef CONFIG_HIGHMEM

extern void *kmap(struct page *page);

extern void kunmap(struct page *page);

extern void *kmap_atomic(struct page *page);

extern void __kunmap_atomic(void *kvaddr);

arch/arm/mm/highmem.c

+0 −9
Original line number Diff line number Diff line
@@ -31,15 +31,6 @@ static inline pte_t get_fixmap_pte(unsigned long vaddr) 
	return *ptep;

}



void *kmap(struct page *page)

{

	might_sleep();

	if (!PageHighMem(page))

		return page_address(page);

	return kmap_high(page);

}

EXPORT_SYMBOL(kmap);



void kunmap(struct page *page)

{

	might_sleep();

arch/csky/include/asm/highmem.h

+2 −2
Original line number Diff line number Diff line
@@ -30,10 +30,10 @@ extern pte_t *pkmap_page_table; 
#define PKMAP_NR(virt)  ((virt-PKMAP_BASE) >> PAGE_SHIFT)

#define PKMAP_ADDR(nr)  (PKMAP_BASE + ((nr) << PAGE_SHIFT))



extern void *kmap_high(struct page *page);

extern void kunmap_high(struct page *page);



extern void *kmap(struct page *page);

#define ARCH_HAS_KMAP_FLUSH_TLB

extern void kmap_flush_tlb(unsigned long addr);

extern void kunmap(struct page *page);

extern void *kmap_atomic(struct page *page);

extern void __kunmap_atomic(void *kvaddr);

CRA Git | Maintained and supported by SUSTech CRA and CCSE