Commit 524ee36f authored May 07, 2010 by Dave Chinner Committed by Alex Elder May 24, 2010

xfs: Don't reuse the same transaction ID for duplicated transactions.



The transaction ID is written into the log as the unique identifier
for transactions during recover. When duplicating a transaction, we
reuse the log ticket, which means it has the same transaction ID as
the previous transaction.

Rather than regenerating a random transaction ID for the duplicated
transaction, just add one to the current ID so that duplicated
transaction can be easily spotted in the log and during recovery
during problem diagnosis.

Signed-off-by: Dave Chinner <dchinner@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>

parent b4ed4626

fs/xfs/xfs_log.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -360,6 +360,15 @@ xfs_log_reserve(
		ASSERT(flags & XFS_LOG_PERM_RESERV);
		internal_ticket = *ticket;

		/*
		* this is a new transaction on the ticket, so we need to
		* change the transaction ID so that the next transaction has a
		* different TID in the log. Just add one to the existing tid
		* so that we can see chains of rolling transactions in the log
		* easily.
		*/
		internal_ticket->t_tid++;

		trace_xfs_log_reserve(log, internal_ticket);

		xlog_grant_push_ail(mp, internal_ticket->t_unit_res);

Admin message