Commit 52403cfb authored Oct 22, 2019 by Johan Hovold Committed by Greg Kroah-Hartman Oct 28, 2019

USB: ldusb: fix control-message timeout



USB control-message timeouts are specified in milliseconds, not jiffies.
Waiting 83 minutes for a transfer to complete is a bit excessive.

Fixes: 2824bd25 ("[PATCH] USB: add ldusb driver")
Cc: stable <stable@vger.kernel.org>     # 2.6.13
Reported-by:  <syzbot+a4fbb3bb76cda0ea4e58@syzkaller.appspotmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://lore.kernel.org/r/20191022153127.22295-1-johan@kernel.org


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 88f6bf38

drivers/usb/misc/ldusb.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -581,7 +581,7 @@ static ssize_t ld_usb_write(struct file file, const char __user buffer,
		1 << 8, 0,
		dev->interrupt_out_buffer,
		bytes_to_write,
		USB_CTRL_SET_TIMEOUT * HZ);
		USB_CTRL_SET_TIMEOUT);
		if (retval < 0)
		dev_err(&dev->intf->dev,
		"Couldn't submit HID_REQ_SET_REPORT %d\n",

Admin message