Commit 522587e7 authored Apr 07, 2020 by Dan Carpenter Committed by Greg Kroah-Hartman Apr 28, 2020

bus: mhi: core: Fix a NULL vs IS_ERR check in mhi_create_devices()



The mhi_alloc_device() function never returns NULL, it returns error
pointers.

Fixes: da1c4f85 ("bus: mhi: core: Add support for creating and destroying MHI devices")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Link: https://lore.kernel.org/r/20200407093133.GM68494@mwanda


Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6a8b55ed

drivers/bus/mhi/core/main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -294,7 +294,7 @@ void mhi_create_devices(struct mhi_controller *mhi_cntrl)
		!(mhi_chan->ee_mask & BIT(mhi_cntrl->ee)))
		continue;
		mhi_dev = mhi_alloc_device(mhi_cntrl);
		if (!mhi_dev)
		if (IS_ERR(mhi_dev))
		return;

		mhi_dev->dev_type = MHI_DEVICE_XFER;

Admin message