Commit 5224fa36 authored Mar 23, 2011 by Tejun Heo

ptrace: Make do_signal_stop() use ptrace_stop() if the task is being ptraced



A ptraced task would still stop at do_signal_stop() when it's stopping
for stop signals and do_signal_stop() behaves the same whether the
task is ptraced or not.  However, in addition to stopping,
ptrace_stop() also does ptrace specific stuff like calling
architecture specific callbacks, so this behavior makes the code more
fragile and difficult to understand.

This patch makes do_signal_stop() test whether the task is ptraced and
use ptrace_stop() if so.  This renders tracehook_notify_jctl() rather
pointless as the ptrace notification is now handled by ptrace_stop()
regardless of the return value from the tracehook.  It probably is a
good idea to update it.

This doesn't solve the whole problem as tasks already in stopped state
would stay in the regular stop when ptrace attached.  That part will
be handled by the next patch.

Oleg pointed out that this makes a userland-visible change.  Before,
SIGCONT would be able to wake up a task in group stop even if the task
is ptraced if the tracer hasn't issued another ptrace command
afterwards (as the next ptrace commands transitions the state into
TASK_TRACED which ignores SIGCONT wakeups).  With this and the next
patch, SIGCONT may race with the transition into TASK_TRACED and is
ignored if the tracee already entered TASK_TRACED.

Another userland visible change of this and the next patch is that the
ptracee's state would now be TASK_TRACED where it used to be
TASK_STOPPED, which is visible via fs/proc.

Signed-off-by: Tejun Heo <tj@kernel.org>
Acked-by: Oleg Nesterov <oleg@redhat.com>
Cc: Roland McGrath <roland@redhat.com>
Cc: Jan Kratochvil <jan.kratochvil@redhat.com>

parent 0ae8ce1c

kernel/signal.c

+25 −18

Original line number	Diff line number	Diff line
		@@ -1783,7 +1783,6 @@ void ptrace_notify(int exit_code)
		static int do_signal_stop(int signr)
		{
		struct signal_struct *sig = current->signal;
		int notify = 0;

		if (!(current->group_stop & GROUP_STOP_PENDING)) {
		unsigned int gstop = GROUP_STOP_PENDING \| GROUP_STOP_CONSUME;
		@@ -1813,18 +1812,20 @@ static int do_signal_stop(int signr)
		} else
		task_clear_group_stop_pending(t);
		}

		current->exit_code = sig->group_exit_code;
		__set_current_state(TASK_STOPPED);

		if (likely(!task_ptrace(current))) {
		int notify = 0;

		/*
		* If there are no other threads in the group, or if there is
		* a group stop in progress and we are the last to stop, report
		* to the parent. When ptraced, every thread reports itself.
		* If there are no other threads in the group, or if there
		* is a group stop in progress and we are the last to stop,
		* report to the parent.
		*/
		if (task_participate_group_stop(current))
		notify = CLD_STOPPED;
		if (task_ptrace(current))
		notify = CLD_STOPPED;

		current->exit_code = sig->group_exit_code;
		__set_current_state(TASK_STOPPED);

		spin_unlock_irq(&current->sighand->siglock);

		@@ -1837,6 +1838,12 @@ static int do_signal_stop(int signr)
		/* Now we don't run again until woken by SIGCONT or SIGKILL */
		schedule();

		spin_lock_irq(&current->sighand->siglock);
		} else
		ptrace_stop(current->exit_code, CLD_STOPPED, 0, NULL);

		spin_unlock_irq(&current->sighand->siglock);

		tracehook_finish_jctl();
		current->exit_code = 0;

Admin message