nvme: trace all async notice events (521cfb8e) · Commits · 戴 / test

This patch removes the tracing of the NVMe Async events out of the switch so that it can trace all the events including the ones which are not handled in the nvme_handle_aen_notice(). The events which are not handled in the nvme_handle_aen_notice() such as NVME_AER_NOTICE_DISC_CHANGED corresponding event identifier needs to be added in the drivers/nvme/host/trace.h so that it can stringify the AER . Signed-off-by:

Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com> Signed-off-by:

Christoph Hellwig <hch@lst.de>

drivers/nvme/host/core.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -3604,19 +3604,18 @@ static void nvme_handle_aen_notice(struct nvme_ctrl *ctrl, u32 result)
		{
		u32 aer_notice_type = (result & 0xff00) >> 8;

		trace_nvme_async_event(ctrl, aer_notice_type);

		switch (aer_notice_type) {
		case NVME_AER_NOTICE_NS_CHANGED:
		trace_nvme_async_event(ctrl, aer_notice_type);
		set_bit(NVME_AER_NOTICE_NS_CHANGED, &ctrl->events);
		nvme_queue_scan(ctrl);
		break;
		case NVME_AER_NOTICE_FW_ACT_STARTING:
		trace_nvme_async_event(ctrl, aer_notice_type);
		queue_work(nvme_wq, &ctrl->fw_act_work);
		break;
		#ifdef CONFIG_NVME_MULTIPATH
		case NVME_AER_NOTICE_ANA:
		trace_nvme_async_event(ctrl, aer_notice_type);
		if (!ctrl->ana_log_buf)
		break;
		queue_work(nvme_wq, &ctrl->ana_work);

drivers/nvme/host/trace.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -167,6 +167,7 @@ TRACE_EVENT(nvme_async_event,
		aer_name(NVME_AER_NOTICE_NS_CHANGED),
		aer_name(NVME_AER_NOTICE_ANA),
		aer_name(NVME_AER_NOTICE_FW_ACT_STARTING),
		aer_name(NVME_AER_NOTICE_DISC_CHANGED),
		aer_name(NVME_AER_ERROR),
		aer_name(NVME_AER_SMART),
		aer_name(NVME_AER_CSS),

Admin message