Commit 521c4299 authored Apr 15, 2014 by Viresh Kumar Committed by Thomas Gleixner Apr 15, 2014

tick-common: Fix wrong check in tick_check_replacement()



tick_check_replacement() returns if a replacement of clock_event_device is
possible or not. It does this as the first check:

	if (tick_check_percpu(curdev, newdev, smp_processor_id()))
		return false;

Thats wrong. tick_check_percpu() returns true when the device is
useable. Check for false instead.

[ tglx: Massaged changelog ]

Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
Cc: <stable@vger.kernel.org> # v3.11+
Cc: linaro-kernel@lists.linaro.org
Cc: fweisbec@gmail.com
Cc: Arvind.Chauhan@arm.com
Cc: linaro-networking@linaro.org
Link: http://lkml.kernel.org/r/486a02efe0246635aaba786e24b42d316438bf3b.1397537987.git.viresh.kumar@linaro.org


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent 55101e2d

kernel/time/tick-common.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -276,7 +276,7 @@ static bool tick_check_preferred(struct clock_event_device *curdev,
		bool tick_check_replacement(struct clock_event_device *curdev,
		struct clock_event_device *newdev)
		{
		if (tick_check_percpu(curdev, newdev, smp_processor_id()))
		if (!tick_check_percpu(curdev, newdev, smp_processor_id()))
		return false;

		return tick_check_preferred(curdev, newdev);

Admin message