Commit 52176e70 authored Mar 23, 2009 by Santosh Shilimkar Committed by Tony Lindgren Mar 23, 2009

ARM: OMAP: Dispatch only relevant DMA interrupts



This fixes the spurious interrupt issue on a DMA channel.

In OMAP sDMA, contrast to the SDMA.DMA4_CSRi registers, the
SDMA.DMA4_IRQSTATUS_Lj registers are updated regardless of
the corresponding bits in the SDMA.DMA4_IRQENABLE_Lj registers.
Since there are four sDMA interrupt lines and if more than one
line is actively used by two concurrently running sDMA softwares
modules,then the spurious interrupt can be observed on the other
lines.

Fix in this patch will only dispatch the relevant and enabled
interrupts on a particular line thus perevting spurious IRQ.

Signed-off-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Nishant Kamat <nskamat@ti.com>
Signed-off-by: Tony Lindgren <tony@atomide.com>

parent 2263f022

arch/arm/plat-omap/dma.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1901,7 +1901,7 @@ static int omap2_dma_handle_ch(int ch)
		/* STATUS register count is from 1-32 while our is 0-31 */
		static irqreturn_t omap2_dma_irq_handler(int irq, void *dev_id)
		{
		u32 val;
		u32 val, enable_reg;
		int i;

		val = dma_read(IRQSTATUS_L0);
		@@ -1910,6 +1910,8 @@ static irqreturn_t omap2_dma_irq_handler(int irq, void *dev_id)
		printk(KERN_WARNING "Spurious DMA IRQ\n");
		return IRQ_HANDLED;
		}
		enable_reg = dma_read(IRQENABLE_L0);
		val &= enable_reg; /* Dispatch only relevant interrupts */
		for (i = 0; i < dma_lch_count && val != 0; i++) {
		if (val & 1)
		omap2_dma_handle_ch(i);

Admin message