s390/claw: remove "eieio" calls (521674e4) · Commits · 戴 / test

If the code really depends on ordering it's already racy. The additional memory barriers (eieio) don't help with that. If the code is not racy the memory barriers also aren't needed. In any case, just remove them. Signed-off-by:

Heiko Carstens <heiko.carstens@de.ibm.com> Signed-off-by:

Martin Schwidefsky <schwidefsky@de.ibm.com>

drivers/s390/net/claw.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -136,7 +136,6 @@ static inline void
		claw_set_busy(struct net_device *dev)
		{
		((struct claw_privbk *)dev->ml_priv)->tbusy = 1;
		eieio();
		}

		static inline void
		@@ -144,13 +143,11 @@ claw_clear_busy(struct net_device *dev)
		{
		clear_bit(0, &(((struct claw_privbk *) dev->ml_priv)->tbusy));
		netif_wake_queue(dev);
		eieio();
		}

		static inline int
		claw_check_busy(struct net_device *dev)
		{
		eieio();
		return ((struct claw_privbk *) dev->ml_priv)->tbusy;
		}

Admin message