Commit 521394e4 authored Apr 25, 2012 by Stefano Stabellini Committed by Konrad Rzeszutek Wilk Apr 26, 2012

xen: use the pirq number to check the pirq_eoi_map



In pirq_check_eoi_map use the pirq number rather than the Linux irq
number to check whether an eoi is needed in the pirq_eoi_map.

The reason is that the irq number is not always identical to the
pirq number so if we wrongly use the irq number to check the
pirq_eoi_map we are going to check for the wrong pirq to EOI.

As a consequence some interrupts might not be EOI'ed by the
guest correctly.

Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Tested-by: Tobias Geiger <tobias.geiger@vido.info>
[v1: Added some extra wording to git commit]
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

parent df88b2d9

drivers/xen/events.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -274,7 +274,7 @@ static unsigned int cpu_from_evtchn(unsigned int evtchn)

		static bool pirq_check_eoi_map(unsigned irq)
		{
		return test_bit(irq, pirq_eoi_map);
		return test_bit(pirq_from_irq(irq), pirq_eoi_map);
		}

		static bool pirq_needs_eoi_flag(unsigned irq)

Admin message