Commit 5210a63a authored Mar 03, 2016 by Amitoj Kaur Chawla Committed by Greg Kroah-Hartman Mar 02, 2016

staging: lustre: llite: Remove unnecessary test in if condition



Remove unnecessary test on `rc` variable since it has already been
tested previously.
Fixes following smatch warning:
drivers/staging/lustre/lustre/llite/llite_lib.c:1331 ll_setattr_raw()
warn: we tested 'rc' before and it was 'false'

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 7cadcc7c

drivers/staging/lustre/lustre/llite/llite_lib.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1328,7 +1328,7 @@ int ll_setattr_raw(struct dentry dentry, struct iattr attr, bool hsm_import)
		}

		/* RPC to MDT is sent, cancel data modification flag */
		if (rc == 0 && (op_data->op_bias & MDS_DATA_MODIFIED)) {
		if (op_data->op_bias & MDS_DATA_MODIFIED) {
		spin_lock(&lli->lli_lock);
		lli->lli_flags &= ~LLIF_DATA_MODIFIED;
		spin_unlock(&lli->lli_lock);

Admin message