Commit 520e5ba4 authored Sep 23, 2019 by Song Liu Committed by Linus Torvalds Sep 24, 2019

filemap: update offset check in filemap_fault()

With THP, current check of offset:

    VM_BUG_ON_PAGE(page->index != offset, page);

is no longer accurate. Update it to:

    VM_BUG_ON_PAGE(page_to_pgoff(page) != offset, page);

Link: http://lkml.kernel.org/r/20190801184244.3169074-4-songliubraving@fb.com


Signed-off-by: Song Liu <songliubraving@fb.com>
Acked-by: Rik van Riel <riel@surriel.com>
Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Acked-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Hillf Danton <hdanton@sina.com>
Cc: Hugh Dickins <hughd@google.com>
Cc: William Kucharski <william.kucharski@oracle.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 31895438

mm/filemap.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2545,7 +2545,7 @@ retry_find:
		put_page(page);
		goto retry_find;
		}
		VM_BUG_ON_PAGE(page->index != offset, page);
		VM_BUG_ON_PAGE(page_to_pgoff(page) != offset, page);

		/*
		* We have a locked page in the page cache, now we need to check

Admin message