Commit 51f1f6f5 authored Nov 23, 2018 by Rex Zhu Committed by Alex Deucher Nov 26, 2018

drm/amdgpu: Fix static checker warning



drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c:49 amdgpu_allocate_static_csa()
error: uninitialized symbol 'ptr'.

the test if (!bo) doesn't work, as the bo is a pointer to a pointer.
if bo create failed, the *bo will be set to NULL.
so change to test *bo.

Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent 8ca606de

drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -43,7 +43,7 @@ int amdgpu_allocate_static_csa(struct amdgpu_device adev, struct amdgpu_bo *bo
		r = amdgpu_bo_create_kernel(adev, size, PAGE_SIZE,
		domain, bo,
		NULL, &ptr);
		if (!bo)
		if (!*bo)
		return -ENOMEM;

		memset(ptr, 0, size);

Admin message