ARM: davinci: board-da830-evm: fix GPIO lookup for MMC/SD (51e9f121) · Commits · 戴 / test

The GPIO chip is called davinci_gpio.0 in legacy mode. Fix it, so that mmc can correctly lookup the wp and cp gpios. Also fix the GPIO numbers as they are not offsets within a bank. Note that it is the gpio-davinci driver that sets the gpiochip label to davinci_gpio.0. Fixes: ("ARM: davinci: da830-evm: use gpio descriptor for mmc pins") Reported-by:

David Lechner <david@lechnology.com> Reviewed-by:

David Lechner <david@lechnology.com> Signed-off-by:

Sekhar Nori <nsekhar@ti.com>

arch/arm/mach-davinci/board-da830-evm.c

+7 −2

Original line number	Diff line number	Diff line
		@@ -205,12 +205,17 @@ static const short da830_evm_mmc_sd_pins[] = {
		-1
		};

		#define DA830_MMCSD_WP_PIN GPIO_TO_PIN(2, 1)
		#define DA830_MMCSD_CD_PIN GPIO_TO_PIN(2, 2)

		static struct gpiod_lookup_table mmc_gpios_table = {
		.dev_id = "da830-mmc.0",
		.table = {
		/* gpio chip 1 contains gpio range 32-63 */
		GPIO_LOOKUP("davinci_gpio.1", 2, "cd", GPIO_ACTIVE_LOW),
		GPIO_LOOKUP("davinci_gpio.1", 1, "wp", GPIO_ACTIVE_LOW),
		GPIO_LOOKUP("davinci_gpio.0", DA830_MMCSD_CD_PIN, "cd",
		GPIO_ACTIVE_LOW),
		GPIO_LOOKUP("davinci_gpio.0", DA830_MMCSD_WP_PIN, "wp",
		GPIO_ACTIVE_LOW),
		},
		};

Admin message