Commit 51d8838d authored Jan 17, 2019 by Jerry Snitselaar Committed by Joerg Roedel Jan 22, 2019

iommu/amd: Call free_iova_fast with pfn in map_sg

In the error path of map_sg, free_iova_fast is being called with
address instead of the pfn. This results in a bad value getting into
the rcache, and can result in hitting a BUG_ON when
iova_magazine_free_pfns is called.

Cc: Joerg Roedel <joro@8bytes.org>
Cc: Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Signed-off-by: Jerry Snitselaar <jsnitsel@redhat.com>
Fixes: 80187fd3 ("iommu/amd: Optimize map_sg and unmap_sg")
Signed-off-by: Joerg Roedel <jroedel@suse.de>

parent e8e683ae

drivers/iommu/amd_iommu.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -2623,7 +2623,7 @@ out_unmap:
		}

		out_free_iova:
		free_iova_fast(&dma_dom->iovad, address, npages);
		free_iova_fast(&dma_dom->iovad, address >> PAGE_SHIFT, npages);

		out_err:
		return 0;

Admin message