Commit 51d87bc2 authored Mar 22, 2018 by Fengguang Wu Committed by J. Bruce Fields Apr 03, 2018

nfsd: fix boolreturn.cocci warnings



fs/nfsd/nfs4state.c:926:8-9: WARNING: return of 0/1 in function 'nfs4_delegation_exists' with return type bool
fs/nfsd/nfs4state.c:2955:9-10: WARNING: return of 0/1 in function 'nfsd4_compound_in_session' with return type bool

 Return statements in functions returning bool should use
 true/false instead of 1/0.
Generated by: scripts/coccinelle/misc/boolreturn.cocci

Fixes: 68b18f52 ("nfsd: make nfs4_get_existing_delegation less confusing")
Signed-off-by: Fengguang Wu <fengguang.wu@intel.com>
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
[bfields: also fix -EAGAIN]
Signed-off-by: J. Bruce Fields <bfields@redhat.com>

parent 353601e7

fs/nfsd/nfs4state.c

+3 −3

Original line number	Diff line number	Diff line
		@@ -935,10 +935,10 @@ nfs4_delegation_exists(struct nfs4_client clp, struct nfs4_file fp)
		list_for_each_entry(searchdp, &fp->fi_delegations, dl_perfile) {
		searchclp = searchdp->dl_stid.sc_client;
		if (clp == searchclp) {
		return -EAGAIN;
		return true;
		}
		}
		return 0;
		return false;
		}

		/**
		@@ -2958,7 +2958,7 @@ out_no_session:
		static bool nfsd4_compound_in_session(struct nfsd4_session session, struct nfs4_sessionid sid)
		{
		if (!session)
		return 0;
		return false;
		return !memcmp(sid, &session->se_sessionid, sizeof(*sid));
		}

Admin message