Commit 51cae673 authored Feb 19, 2020 by Amol Grover Committed by Chuck Lever Mar 16, 2020

sunrpc: Pass lockdep expression to RCU lists



detail->hash_table[] is traversed using hlist_for_each_entry_rcu
outside an RCU read-side critical section but under the protection
of detail->hash_lock.

Hence, add corresponding lockdep expression to silence false-positive
warnings, and harden RCU lists.

Signed-off-by: Amol Grover <frextrite@gmail.com>
Signed-off-by: J. Bruce Fields <bfields@redhat.com>
Signed-off-by: Chuck Lever <chuck.lever@oracle.com>

parent 469aef23

net/sunrpc/cache.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -113,7 +113,8 @@ static struct cache_head sunrpc_cache_add_entry(struct cache_detail detail,
		spin_lock(&detail->hash_lock);

		/* check if entry appeared while we slept */
		hlist_for_each_entry_rcu(tmp, head, cache_list) {
		hlist_for_each_entry_rcu(tmp, head, cache_list,
		lockdep_is_held(&detail->hash_lock)) {
		if (detail->match(tmp, key)) {
		if (cache_is_expired(detail, tmp)) {
		sunrpc_begin_cache_remove_entry(tmp, detail);

Admin message