Commit 51c100a6 authored Oct 03, 2019 by Sakari Ailus Committed by Rafael J. Wysocki Oct 11, 2019

software node: Get reference to parent swnode in get_parent op

The software_node_get_parent() returned a pointer to the parent swnode,
but did not take a reference to it, leading the caller to put a reference
that was not taken. Take that reference now.

Fixes: 59abd836 ("drivers: base: Introducing software nodes to the firmware node framework")
Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>

parent da0c9ea1

drivers/base/swnode.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -520,7 +520,10 @@ software_node_get_parent(const struct fwnode_handle *fwnode)
		{
		struct swnode *swnode = to_swnode(fwnode);

		return swnode ? (swnode->parent ? &swnode->parent->fwnode : NULL) : NULL;
		if (!swnode \|\| !swnode->parent)
		return NULL;

		return fwnode_handle_get(&swnode->parent->fwnode);
		}

		static struct fwnode_handle *