Commit 51b3e270 authored Mar 12, 2009 by Andrew Klossner Committed by Jean Delvare Mar 12, 2009

hwmon: (f75375s) Remove unnecessary and confusing initialization



f75375_probe calls i2c_get_clientdata to initialize the data pointer,
but there isn't yet any client data to get, and the value is never
used before the variable is assigned a new value seven lines later.

The call doesn't hurt anything and wastes only a couple of cycles.
The reason to fix it is because this module serves as an example to
hackers writing new hwmon drivers, and this part of the example is
confusing.

Signed-off-by: Andrew Klossner <andrew@cesa.opbu.xerox.com>
Signed-off-by: Jean Delvare <khali@linux-fr.org>

parent e267d250

drivers/hwmon/f75375s.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -617,7 +617,7 @@ static void f75375_init(struct i2c_client client, struct f75375_data data,
		static int f75375_probe(struct i2c_client *client,
		const struct i2c_device_id *id)
		{
		struct f75375_data *data = i2c_get_clientdata(client);
		struct f75375_data *data;
		struct f75375s_platform_data *f75375s_pdata = client->dev.platform_data;
		int err;

Admin message