Commit 518693ab authored by Gustavo A. R. Silva's avatar Gustavo A. R. Silva Committed by Miquel Raynal
Browse files

mtd: lpddr: Replace printk with pr_notice 



pr_notice is preferred over printk.

Also, coalesce formats as coalescing is part of coding-style:
"never break user-visible strings such as printk messages"

Suggested-by: default avatarJoe Perches <joe@perches.com>
Signed-off-by: default avatarGustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Signed-off-by: default avatarMiquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/ff48ce07ef208ba65b858f09279a3b36031d64d2.1588016644.git.gustavo@embeddedor.com
parent 1c9c02bb

include/linux/mtd/pfow.h

+11 −16
Original line number Diff line number Diff line
@@ -127,31 +127,26 @@ static inline void print_drs_error(unsigned dsr) 
	int prog_status = (dsr & DSR_RPS) >> 8;



	if (!(dsr & DSR_AVAILABLE))

		printk(KERN_NOTICE"DSR.15: (0) Device not Available\n");

		pr_notice("DSR.15: (0) Device not Available\n");

	if ((prog_status & 0x03) == 0x03)

		printk(KERN_NOTICE"DSR.9,8: (11) Attempt to program invalid "

						"half with 41h command\n");

		pr_notice("DSR.9,8: (11) Attempt to program invalid half with 41h command\n");

	else if (prog_status & 0x02)

		printk(KERN_NOTICE"DSR.9,8: (10) Object Mode Program attempt "

					"in region with Control Mode data\n");

		pr_notice("DSR.9,8: (10) Object Mode Program attempt in region with Control Mode data\n");

	else if (prog_status &  0x01)

		printk(KERN_NOTICE"DSR.9,8: (01) Program attempt in region "

						"with Object Mode data\n");

		pr_notice("DSR.9,8: (01) Program attempt in region with Object Mode data\n");

	if (!(dsr & DSR_READY_STATUS))

		printk(KERN_NOTICE"DSR.7: (0) Device is Busy\n");

		pr_notice("DSR.7: (0) Device is Busy\n");

	if (dsr & DSR_ESS)

		printk(KERN_NOTICE"DSR.6: (1) Erase Suspended\n");

		pr_notice("DSR.6: (1) Erase Suspended\n");

	if (dsr & DSR_ERASE_STATUS)

		printk(KERN_NOTICE"DSR.5: (1) Erase/Blank check error\n");

		pr_notice("DSR.5: (1) Erase/Blank check error\n");

	if (dsr & DSR_PROGRAM_STATUS)

		printk(KERN_NOTICE"DSR.4: (1) Program Error\n");

		pr_notice("DSR.4: (1) Program Error\n");

	if (dsr & DSR_VPPS)

		printk(KERN_NOTICE"DSR.3: (1) Vpp low detect, operation "

					"aborted\n");

		pr_notice("DSR.3: (1) Vpp low detect, operation aborted\n");

	if (dsr & DSR_PSS)

		printk(KERN_NOTICE"DSR.2: (1) Program suspended\n");

		pr_notice("DSR.2: (1) Program suspended\n");

	if (dsr & DSR_DPS)

		printk(KERN_NOTICE"DSR.1: (1) Aborted Erase/Program attempt "

					"on locked block\n");

		pr_notice("DSR.1: (1) Aborted Erase/Program attempt on locked block\n");

}

#endif /* __LINUX_MTD_PFOW_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE