Commit 5160ee6f authored by Eric Dumazet's avatar Eric Dumazet Committed by Linus Torvalds
Browse files

[PATCH] shrink dentry struct 



Some long time ago, dentry struct was carefully tuned so that on 32 bits
UP, sizeof(struct dentry) was exactly 128, ie a power of 2, and a multiple
of memory cache lines.

Then RCU was added and dentry struct enlarged by two pointers, with nice
results for SMP, but not so good on UP, because breaking the above tuning
(128 + 8 = 136 bytes)

This patch reverts this unwanted side effect, by using an union (d_u),
where d_rcu and d_child are placed so that these two fields can share their
memory needs.

At the time d_free() is called (and d_rcu is really used), d_child is known
to be empty and not touched by the dentry freeing.

Lockless lookups only access d_name, d_parent, d_lock, d_op, d_flags (so
the previous content of d_child is not needed if said dentry was unhashed
but still accessed by a CPU because of RCU constraints)

As dentry cache easily contains millions of entries, a size reduction is
worth the extra complexity of the ugly C union.

Signed-off-by: default avatarEric Dumazet <dada1@cosmosbay.com>
Cc: Dipankar Sarma <dipankar@in.ibm.com>
Cc: Maneesh Soni <maneesh@in.ibm.com>
Cc: Miklos Szeredi <miklos@szeredi.hu>
Cc: "Paul E. McKenney" <paulmck@us.ibm.com>
Cc: Ian Kent <raven@themaw.net>
Cc: Paul Jackson <pj@sgi.com>
Cc: Al Viro <viro@ftp.linux.org.uk>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: Neil Brown <neilb@cse.unsw.edu.au>
Cc: James Morris <jmorris@namei.org>
Cc: Stephen Smalley <sds@epoch.ncsc.mil>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@osdl.org>
parent 21b6bf14

drivers/usb/core/inode.c

+3 −3
Original line number Diff line number Diff line
@@ -186,7 +186,7 @@ static void update_bus(struct dentry *bus) 


	down(&bus->d_inode->i_sem);



	list_for_each_entry(dev, &bus->d_subdirs, d_child)

	list_for_each_entry(dev, &bus->d_subdirs, d_u.d_child)

		if (dev->d_inode)

			update_dev(dev);
@@ -203,7 +203,7 @@ static void update_sb(struct super_block *sb) 


	down(&root->d_inode->i_sem);



	list_for_each_entry(bus, &root->d_subdirs, d_child) {

	list_for_each_entry(bus, &root->d_subdirs, d_u.d_child) {

		if (bus->d_inode) {

			switch (S_IFMT & bus->d_inode->i_mode) {

			case S_IFDIR:
@@ -319,7 +319,7 @@ static int usbfs_empty (struct dentry *dentry) 
	spin_lock(&dcache_lock);



	list_for_each(list, &dentry->d_subdirs) {

		struct dentry *de = list_entry(list, struct dentry, d_child);

		struct dentry *de = list_entry(list, struct dentry, d_u.d_child);

		if (usbfs_positive(de)) {

			spin_unlock(&dcache_lock);

			return 0;

fs/autofs4/autofs_i.h

+1 −1
Original line number Diff line number Diff line
@@ -209,7 +209,7 @@ static inline int simple_empty_nolock(struct dentry *dentry) 
	struct dentry *child;

	int ret = 0;



	list_for_each_entry(child, &dentry->d_subdirs, d_child)

	list_for_each_entry(child, &dentry->d_subdirs, d_u.d_child)

		if (simple_positive(child))

			goto out;

	ret = 1;

fs/autofs4/expire.c

+6 −6
Original line number Diff line number Diff line
@@ -105,7 +105,7 @@ repeat: 
	next = this_parent->d_subdirs.next;

resume:

	while (next != &this_parent->d_subdirs) {

		struct dentry *dentry = list_entry(next, struct dentry, d_child);

		struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child);



		/* Negative dentry - give up */

		if (!simple_positive(dentry)) {
@@ -138,7 +138,7 @@ resume: 
	}



	if (this_parent != top) {

		next = this_parent->d_child.next;

		next = this_parent->d_u.d_child.next;

		this_parent = this_parent->d_parent;

		goto resume;

	}
@@ -163,7 +163,7 @@ repeat: 
	next = this_parent->d_subdirs.next;

resume:

	while (next != &this_parent->d_subdirs) {

		struct dentry *dentry = list_entry(next, struct dentry, d_child);

		struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child);



		/* Negative dentry - give up */

		if (!simple_positive(dentry)) {
@@ -199,7 +199,7 @@ cont: 
	}



	if (this_parent != parent) {

		next = this_parent->d_child.next;

		next = this_parent->d_u.d_child.next;

		this_parent = this_parent->d_parent;

		goto resume;

	}
@@ -238,7 +238,7 @@ static struct dentry *autofs4_expire(struct super_block *sb, 
	/* On exit from the loop expire is set to a dgot dentry

	 * to expire or it's NULL */

	while ( next != &root->d_subdirs ) {

		struct dentry *dentry = list_entry(next, struct dentry, d_child);

		struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child);



		/* Negative dentry - give up */

		if ( !simple_positive(dentry) ) {
@@ -302,7 +302,7 @@ next: 
			expired, (int)expired->d_name.len, expired->d_name.name);

		spin_lock(&dcache_lock);

		list_del(&expired->d_parent->d_subdirs);

		list_add(&expired->d_parent->d_subdirs, &expired->d_child);

		list_add(&expired->d_parent->d_subdirs, &expired->d_u.d_child);

		spin_unlock(&dcache_lock);

		return expired;

	}

fs/autofs4/inode.c

+2 −2
Original line number Diff line number Diff line
@@ -91,7 +91,7 @@ repeat: 
	next = this_parent->d_subdirs.next;

resume:

	while (next != &this_parent->d_subdirs) {

		struct dentry *dentry = list_entry(next, struct dentry, d_child);

		struct dentry *dentry = list_entry(next, struct dentry, d_u.d_child);



		/* Negative dentry - don`t care */

		if (!simple_positive(dentry)) {
@@ -117,7 +117,7 @@ resume: 
	if (this_parent != sbi->root) {

		struct dentry *dentry = this_parent;



		next = this_parent->d_child.next;

		next = this_parent->d_u.d_child.next;

		this_parent = this_parent->d_parent;

		spin_unlock(&dcache_lock);

		DPRINTK("parent dentry %p %.*s",

fs/autofs4/root.c

+2 −1
Original line number Diff line number Diff line
@@ -143,7 +143,8 @@ static int autofs4_dcache_readdir(struct file * filp, void * dirent, filldir_t f 
			}



			while(1) {

				struct dentry *de = list_entry(list, struct dentry, d_child);

				struct dentry *de = list_entry(list,

						struct dentry, d_u.d_child);



				if (!d_unhashed(de) && de->d_inode) {

					spin_unlock(&dcache_lock);

CRA Git | Maintained and supported by SUSTech CRA and CCSE