Commit 5150bf19 authored Apr 17, 2020 by Filipe Manana Committed by David Sterba Apr 23, 2020

btrfs: fix memory leak of transaction when deleting unused block group



When cleaning pinned extents right before deleting an unused block group,
we check if there's still a previous transaction running and if so we
increment its reference count before using it for cleaning pinned ranges
in its pinned extents iotree. However we ended up never decrementing the
reference count after using the transaction, resulting in a memory leak.

Fix it by decrementing the reference count.

Fixes: fe119a6e ("btrfs: switch to per-transaction pinned extents")
Signed-off-by: Filipe Manana <fdmanana@suse.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 317ddf37

fs/btrfs/block-group.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -1288,11 +1288,15 @@ static bool clean_pinned_extents(struct btrfs_trans_handle *trans,
		if (ret)
		goto err;
		mutex_unlock(&fs_info->unused_bg_unpin_mutex);
		if (prev_trans)
		btrfs_put_transaction(prev_trans);

		return true;

		err:
		mutex_unlock(&fs_info->unused_bg_unpin_mutex);
		if (prev_trans)
		btrfs_put_transaction(prev_trans);
		btrfs_dec_block_group_ro(bg);
		return false;
		}

Admin message