Commit 5150bda4 authored Aug 09, 2010 by Joe Eloff Committed by Linus Torvalds Aug 09, 2010

checkpatch: change externals to globals

Make error message say 'ERROR: do not initialise globals to 0 or NULL'
rather than 'ERROR: do not initialise externals to 0 or NULL'.  Makes more
sense in the context since there is an extern keyword in C and that is a
global declaration within the scope of the current file.

Signed-off-by: Joe Eloff <kagen101@gmail.com>
Cc: Andy Whitcroft <apw@shadowen.org>
Cc: Wolfram Sang <w.sang@pengutronix.de>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 5f7ddae6

scripts/checkpatch.pl

+2 −2

Original line number	Diff line number	Diff line
		@@ -1791,9 +1791,9 @@ sub process {
		WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
		}

		# check for external initialisers.
		# check for global initialisers.
		if ($line =~ /^.$Type\s$Ident\s(?:\s+$Modifier)\s=\s(0\|NULL\|false)\s;/) {
		ERROR("do not initialise externals to 0 or NULL\n" .
		ERROR("do not initialise globals to 0 or NULL\n" .
		$herecurr);
		}
		# check for static initialisers.

Admin message