Commit 514ab34d authored Jul 14, 2017 by Ian Jamison Committed by Greg Kroah-Hartman Jul 17, 2017

serial: imx: Prevent TX buffer PIO write when a DMA has been started



Function imx_transmit_buffer starts a TX DMA if DMA is enabled, since
commit 91a1a909 ("serial: imx: Support sw flow control in DMA mode").
It also carries on and attempts to write the same TX buffer using PIO.
This results in TX data corruption and double-incrementing xmit->tail
with the knock-on effect of tail passing head and a page of garbage
being sent out.

This seems to be triggered mostly when using RS485 half duplex on SMP
systems, but is probably not limited to just those.

Tested locally on an i.MX6Q with an RS485 half duplex transceiver on
UART3, and also by Clemens Gruber.

Tested-by: Clemens Gruber <clemens.gruber@pqgruber.com>
Signed-off-by: Ian Jamison <ian.dev@arkver.com>
Reviewed-by: Fabio Estevam <fabio.estevam@nxp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 351ea50d

drivers/tty/serial/imx.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -458,7 +458,7 @@ static inline void imx_transmit_buffer(struct imx_port *sport)
		}
		}

		while (!uart_circ_empty(xmit) &&
		while (!uart_circ_empty(xmit) && !sport->dma_is_txing &&
		!(readl(sport->port.membase + uts_reg(sport)) & UTS_TXFULL)) {
		/* send xmit->buf[xmit->tail]
		* out the port here */

Admin message