Commit 514a6dc9 authored by James Smart's avatar James Smart Committed by Christoph Hellwig
Browse files

nvme-fc: fix error loop in create_hw_io_queues 



The loop that backs out of hw io queue creation continues through index
0, which corresponds to the admin queue as well.

Fix the loop so it only proceeds through indexes 1..n which correspond to
I/O queues.

Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Reviewed-by: default avatarHimanshu Madhani <himanshu.madhani@oracle.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.de>
Signed-off-by: default avatarChristoph Hellwig <hch@lst.de>
parent 52793d62

drivers/nvme/host/fc.c

+2 −2
Original line number Diff line number Diff line
@@ -2317,7 +2317,7 @@ nvme_fc_create_hw_io_queues(struct nvme_fc_ctrl *ctrl, u16 qsize) 
	return 0;



delete_queues:

	for (; i >= 0; i--)

	for (; i > 0; i--)

		__nvme_fc_delete_hw_queue(ctrl, &ctrl->queues[i], i);

	return ret;

}
@@ -2436,7 +2436,7 @@ nvme_fc_error_recovery(struct nvme_fc_ctrl *ctrl, char *errmsg) 
		return;



	dev_warn(ctrl->ctrl.device,

		"NVME-FC{%d}: transport association error detected: %s\n",

		"NVME-FC{%d}: transport association event: %s\n",

		ctrl->cnum, errmsg);

	dev_warn(ctrl->ctrl.device,

		"NVME-FC{%d}: resetting controller\n", ctrl->cnum);

CRA Git | Maintained and supported by SUSTech CRA and CCSE