Commit 514838e9 authored by Stephen Boyd's avatar Stephen Boyd Committed by Herbert Xu
Browse files

crypto: drivers - Remove dev_err() usage after platform_get_irq() 



We don't need dev_err() messages when platform_get_irq() fails now that
platform_get_irq() prints an error message itself when something goes
wrong. Let's remove these prints with a simple semantic patch.

// <smpl>
@@
expression ret;
struct platform_device *E;
@@

ret =
(
platform_get_irq(E, ...)
|
platform_get_irq_byname(E, ...)
);

if ( \( ret < 0 \| ret <= 0 \) )
{
(
-if (ret != -EPROBE_DEFER)
-{ ...
-dev_err(...);
-... }
|
...
-dev_err(...);
)
...
}
// </smpl>

While we're here, remove braces on if statements that only have one
statement (manually).

Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: <linux-crypto@vger.kernel.org>
Signed-off-by: default avatarStephen Boyd <swboyd@chromium.org>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent f26882a3

drivers/crypto/atmel-aes.c

+0 −1
Original line number Diff line number Diff line
@@ -2673,7 +2673,6 @@ static int atmel_aes_probe(struct platform_device *pdev) 
	/* Get the IRQ */

	aes_dd->irq = platform_get_irq(pdev,  0);

	if (aes_dd->irq < 0) {

		dev_err(dev, "no IRQ resource info\n");

		err = aes_dd->irq;

		goto res_err;

	}

drivers/crypto/atmel-sha.c

+0 −1
Original line number Diff line number Diff line
@@ -2779,7 +2779,6 @@ static int atmel_sha_probe(struct platform_device *pdev) 
	/* Get the IRQ */

	sha_dd->irq = platform_get_irq(pdev,  0);

	if (sha_dd->irq < 0) {

		dev_err(dev, "no IRQ resource info\n");

		err = sha_dd->irq;

		goto res_err;

	}

drivers/crypto/atmel-tdes.c

+0 −1
Original line number Diff line number Diff line
@@ -1281,7 +1281,6 @@ static int atmel_tdes_probe(struct platform_device *pdev) 
	/* Get the IRQ */

	tdes_dd->irq = platform_get_irq(pdev,  0);

	if (tdes_dd->irq < 0) {

		dev_err(dev, "no IRQ resource info\n");

		err = tdes_dd->irq;

		goto res_err;

	}

drivers/crypto/ccree/cc_driver.c

+1 −3
Original line number Diff line number Diff line
@@ -338,10 +338,8 @@ static int init_cc_resources(struct platform_device *plat_dev) 


	/* Then IRQ */

	new_drvdata->irq = platform_get_irq(plat_dev, 0);

	if (new_drvdata->irq < 0) {

		dev_err(dev, "Failed getting IRQ resource\n");

	if (new_drvdata->irq < 0)

		return new_drvdata->irq;

	}



	init_completion(&new_drvdata->hw_queue_avail);

drivers/crypto/img-hash.c

+0 −1
Original line number Diff line number Diff line
@@ -980,7 +980,6 @@ static int img_hash_probe(struct platform_device *pdev) 


	irq = platform_get_irq(pdev, 0);

	if (irq < 0) {

		dev_err(dev, "no IRQ resource info\n");

		err = irq;

		goto res_err;

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE