Commit 5140a8ce authored Mar 01, 2013 by Tim Gardner Committed by Linus Torvalds Mar 01, 2013

autofs4 - autofs4_catatonic_mode(): remove redundant null check on kfree()



smatch analysis:

  fs/autofs4/waitq.c:46 autofs4_catatonic_mode() info: redundant null check on wq->name.name calling kfree()

Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Ian Kent <raven@themaw.net>
Cc: autofs@vger.kernel.org
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 9d8072e7

fs/autofs4/waitq.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -42,10 +42,8 @@ void autofs4_catatonic_mode(struct autofs_sb_info *sbi)
		while (wq) {
		nwq = wq->next;
		wq->status = -ENOENT; /* Magic is gone - report failure */
		if (wq->name.name) {
		kfree(wq->name.name);
		wq->name.name = NULL;
		}
		wq->wait_ctr--;
		wake_up_interruptible(&wq->queue);
		wq = nwq;

Admin message