Commit 5137d303 authored Dec 08, 2020 by Chris Mi Committed by David S. Miller Dec 09, 2020

net: flow_offload: Fix memory leak for indirect flow block



The offending commit introduces a cleanup callback that is invoked
when the driver module is removed to clean up the tunnel device
flow block. But it returns on the first iteration of the for loop.
The remaining indirect flow blocks will never be freed.

Fixes: 1fac52da ("net: flow_offload: consolidate indirect flow_block infrastructure")
CC: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Chris Mi <cmi@nvidia.com>
Reviewed-by: Roi Dayan <roid@nvidia.com>

parent 8ef44b6f

net/core/flow_offload.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -381,10 +381,8 @@ static void __flow_block_indr_cleanup(void (release)(void cb_priv),

		list_for_each_entry_safe(this, next, &flow_block_indr_list, indr.list) {
		if (this->release == release &&
		this->indr.cb_priv == cb_priv) {
		this->indr.cb_priv == cb_priv)
		list_move(&this->indr.list, cleanup_list);
		return;
		}
		}
		}

Admin message