Commit 5134d2fd authored Jan 23, 2018 by Colin Ian King Committed by Alexandre Belloni Feb 13, 2018

rtc: ds1302: remove redundant initializations of pointer bp



Pointe bp is being initialized and this value is never read, it
is being updated to the same value later just before it is going to
be used. Remove the initialization as it is never read and keep
the setting of bp closer to the use of bp.

Cleans up clang warnings:
drivers/rtc/rtc-ds1302.c:115:7: warning: Value stored to 'bp' during
its initialization is never read
drivers/rtc/rtc-ds1302.c:46:7: warning: Value stored to 'bp' during
its initialization is never read

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

parent 82d632b8

drivers/rtc/rtc-ds1302.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -43,7 +43,7 @@ static int ds1302_rtc_set_time(struct device dev, struct rtc_time time)
		{
		struct spi_device *spi = dev_get_drvdata(dev);
		u8 buf[1 + RTC_CLCK_LEN];
		u8 *bp = buf;
		u8 *bp;
		int status;

		/* Enable writing */
		@@ -112,7 +112,7 @@ static int ds1302_probe(struct spi_device *spi)
		struct rtc_device *rtc;
		u8 addr;
		u8 buf[4];
		u8 *bp = buf;
		u8 *bp;
		int status;

		/* Sanity check board setup data. This may be hooked up

Admin message