Commit 510f85ed authored by Nikolay Borisov's avatar Nikolay Borisov Committed by David Sterba
Browse files

btrfs: remove inode argument from add_pending_csums 



It's used to reference the csum root which can be done from the trans
handle as well. Simplify the signature and while at it also remove the
noinline attribute as the function uses only at most 16 bytes of stack
space.

Signed-off-by: default avatarNikolay Borisov <nborisov@suse.com>
Reviewed-by: default avatarDavid Sterba <dsterba@suse.com>
Signed-off-by: default avatarDavid Sterba <dsterba@suse.com>
parent 3c38c877

fs/btrfs/inode.c

+4 −5
Original line number Diff line number Diff line
@@ -2246,16 +2246,15 @@ out: 
 * given a list of ordered sums record them in the inode.  This happens

 * at IO completion time based on sums calculated at bio submission time.

 */

static noinline int add_pending_csums(struct btrfs_trans_handle *trans,

			     struct inode *inode, struct list_head *list)

static int add_pending_csums(struct btrfs_trans_handle *trans,

			     struct list_head *list)

{

	struct btrfs_ordered_sum *sum;

	int ret;



	list_for_each_entry(sum, list, list) {

		trans->adding_csums = true;

		ret = btrfs_csum_file_blocks(trans,

		       BTRFS_I(inode)->root->fs_info->csum_root, sum);

		ret = btrfs_csum_file_blocks(trans, trans->fs_info->csum_root, sum);

		trans->adding_csums = false;

		if (ret)

			return ret;
@@ -2683,7 +2682,7 @@ static int btrfs_finish_ordered_io(struct btrfs_ordered_extent *ordered_extent) 
		goto out;

	}



	ret = add_pending_csums(trans, inode, &ordered_extent->list);

	ret = add_pending_csums(trans, &ordered_extent->list);

	if (ret) {

		btrfs_abort_transaction(trans, ret);

		goto out;

CRA Git | Maintained and supported by SUSTech CRA and CCSE