Commit 50eab050 authored Mar 27, 2013 by Li RongQing Committed by David S. Miller Mar 29, 2013

net: fix the use of this_cpu_ptr



flush_tasklet is not percpu var, and percpu is percpu var, and
	this_cpu_ptr(&info->cache->percpu->flush_tasklet)
is not equal to
	&this_cpu_ptr(info->cache->percpu)->flush_tasklet

1f743b07(use this_cpu_ptr per-cpu helper) introduced this bug.

Signed-off-by: Li RongQing <roy.qing.li@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 1bc7db16

net/core/flow.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -328,7 +328,7 @@ static void flow_cache_flush_per_cpu(void *data)
		struct flow_flush_info *info = data;
		struct tasklet_struct *tasklet;

		tasklet = this_cpu_ptr(&info->cache->percpu->flush_tasklet);
		tasklet = &this_cpu_ptr(info->cache->percpu)->flush_tasklet;
		tasklet->data = (unsigned long)info;
		tasklet_schedule(tasklet);
		}

Admin message