Commit 50e92915 authored Jan 30, 2013 by Dan Carpenter Committed by James Bottomley Feb 22, 2013

[SCSI] qla4xxx: don't free NULL dma pool



The error path calls dma_pool_free() on this path but "chap_table" is
NULL and "chap_dma" is uninitialized.  It's cleaner to just return
directly.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Vikas Chaudhary <vikas.chaudhary@qlogic.com>
Signed-off-by: James Bottomley <JBottomley@Parallels.com>

parent 7c237c5f

drivers/scsi/qla4xxx/ql4_mbx.c

+2 −4

Original line number	Diff line number	Diff line
		@@ -1420,10 +1420,8 @@ int qla4xxx_get_chap(struct scsi_qla_host ha, char username, char *password,
		dma_addr_t chap_dma;

		chap_table = dma_pool_alloc(ha->chap_dma_pool, GFP_KERNEL, &chap_dma);
		if (chap_table == NULL) {
		ret = -ENOMEM;
		goto exit_get_chap;
		}
		if (chap_table == NULL)
		return -ENOMEM;

		chap_size = sizeof(struct ql4_chap_table);
		memset(chap_table, 0, chap_size);

Admin message