ASoC: imx: check kzalloc() result and fix memory leak (50e8ce14) · Commits · 戴 / test

If kzalloc() fails we must exit with -ENOMEM. Also we must free allocated runtime->private_data on error as it would be lost on next call to snd_imx_open(). Signed-off-by:

Kulikov Vasiliy <segooon@gmail.com> Acked-by:

Liam Girdwood <lrg@slimlogic.co.uk> Signed-off-by:

Mark Brown <broonie@opensource.wolfsonmicro.com>

sound/soc/imx/imx-pcm-fiq.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -192,6 +192,8 @@ static int snd_imx_open(struct snd_pcm_substream *substream)
		int ret;

		iprtd = kzalloc(sizeof(*iprtd), GFP_KERNEL);
		if (iprtd == NULL)
		return -ENOMEM;
		runtime->private_data = iprtd;

		iprtd->substream = substream;
		@@ -202,8 +204,10 @@ static int snd_imx_open(struct snd_pcm_substream *substream)

		ret = snd_pcm_hw_constraint_integer(substream->runtime,
		SNDRV_PCM_HW_PARAM_PERIODS);
		if (ret < 0)
		if (ret < 0) {
		kfree(iprtd);
		return ret;
		}

		snd_soc_set_runtime_hwparams(substream, &snd_imx_hardware);
		return 0;

Admin message