Commit 50e107ff authored Sep 10, 2019 by Lior David Committed by Kalle Valo Sep 12, 2019

wil6210: ignore reset errors for FW during probe



There are special kinds of FW such as WMI only which
are used for testing, diagnostics and other specific
scenario.
Such FW is loaded during driver probe and the driver
disallows enabling any network interface, to avoid
operational issues.
In many cases it is used to debug early versions
of FW with new features, which sometimes fail
on startup.
Currently when such FW fails to load (for example,
because of init failure), the driver probe would fail
and shutdown the device making it difficult to debug
the early failure.
To fix this, ignore load failures in WMI only FW and
allow driver probe to succeed, making it possible to
continue and debug the FW load failure.

Signed-off-by: Lior David <liord@codeaurora.org>
Signed-off-by: Maya Erez <merez@codeaurora.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>

parent 055c8a71

drivers/net/wireless/ath/wil6210/pcie_bus.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -435,7 +435,7 @@ static int wil_pcie_probe(struct pci_dev pdev, const struct pci_device_id id)
		mutex_unlock(&wil->mutex);
		if (rc) {
		wil_err(wil, "failed to load WMI only FW\n");
		goto if_remove;
		/* ignore the error to allow debugging */
		}
		}

		@@ -455,8 +455,6 @@ static int wil_pcie_probe(struct pci_dev pdev, const struct pci_device_id id)

		return 0;

		if_remove:
		wil_if_remove(wil);
		bus_disable:
		wil_if_pcie_disable(wil);
		err_iounmap:

Admin message