Commit 50d24c34 authored Nov 03, 2016 by Shaohua Li Committed by Jens Axboe Nov 03, 2016

block: immediately dispatch big size request



Currently block plug holds up to 16 non-mergeable requests. This makes
sense if the request size is small, eg, reduce lock contention. But if
request size is big enough, we don't need to worry about lock
contention. Holding such request makes no sense and it lows the disk
utilization.

In practice, this improves 10% throughput for my raid5 sequential write
workload.

The size (128k) is arbitrary right now, but it makes sure lock
contention is small. This probably could be more intelligent, eg, check
average request size holded. Since this is mainly for sequential IO,
probably not worthy.

V2: check the last request instead of the first request, so as long as
there is one big size request we flush the plug.

Signed-off-by: Shaohua Li <shli@fb.com>
Signed-off-by: Jens Axboe <axboe@fb.com>

parent 46f3cc17

block/blk-core.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -1746,7 +1746,9 @@ get_rq:
		if (!request_count)
		trace_block_plug(q);
		else {
		if (request_count >= BLK_MAX_REQUEST_COUNT) {
		struct request *last = list_entry_rq(plug->list.prev);
		if (request_count >= BLK_MAX_REQUEST_COUNT \|\|
		blk_rq_bytes(last) >= BLK_PLUG_FLUSH_SIZE) {
		blk_flush_plug_list(plug, false);
		trace_block_plug(q);
		}

include/linux/blkdev.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -1173,6 +1173,7 @@ struct blk_plug {
		struct list_head cb_list; /* md requires an unplug callback */
		};
		#define BLK_MAX_REQUEST_COUNT 16
		#define BLK_PLUG_FLUSH_SIZE (128 * 1024)

		struct blk_plug_cb;
		typedef void (blk_plug_cb_fn)(struct blk_plug_cb , bool);

Admin message