Commit 50bdd430 authored by Glauber Costa's avatar Glauber Costa Committed by Linus Torvalds
Browse files

res_counter: return amount of charges after res_counter_uncharge() 



It is useful to know how many charges are still left after a call to
res_counter_uncharge.  While it is possible to issue a res_counter_read
after uncharge, this can be racy.

If we need, for instance, to take some action when the counters drop down
to 0, only one of the callers should see it.  This is the same semantics
as the atomic variables in the kernel.

Since the current return value is void, we don't need to worry about
anything breaking due to this change: nobody relied on that, and only
users appearing from now on will be checking this value.

Signed-off-by: default avatarGlauber Costa <glommer@parallels.com>
Reviewed-by: default avatarMichal Hocko <mhocko@suse.cz>
Acked-by: default avatarKamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>
Acked-by: default avatarDavid Rientjes <rientjes@google.com>
Cc: Johannes Weiner <hannes@cmpxchg.org>
Cc: Suleiman Souhlal <suleiman@google.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Christoph Lameter <cl@linux.com>
Cc: Frederic Weisbecker <fweisbec@redhat.com>
Cc: Greg Thelen <gthelen@google.com>
Cc: JoonSoo Kim <js1304@gmail.com>
Cc: Mel Gorman <mel@csn.ul.ie>
Cc: Pekka Enberg <penberg@cs.helsinki.fi>
Cc: Rik van Riel <riel@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 6a1a0d3b

Documentation/cgroups/resource_counter.txt

+4 −3
Original line number Diff line number Diff line
@@ -83,16 +83,17 @@ to work with it. 
	res_counter->lock internally (it must be called with res_counter->lock

	held). The force parameter indicates whether we can bypass the limit.



 e. void res_counter_uncharge[_locked]

 e. u64 res_counter_uncharge[_locked]

			(struct res_counter *rc, unsigned long val)



	When a resource is released (freed) it should be de-accounted

	from the resource counter it was accounted to.  This is called

	"uncharging".

	"uncharging". The return value of this function indicate the amount

	of charges still present in the counter.



	The _locked routines imply that the res_counter->lock is taken.



 f. void res_counter_uncharge_until

 f. u64 res_counter_uncharge_until

		(struct res_counter *rc, struct res_counter *top,

		 unsinged long val)

include/linux/res_counter.h

+7 −5
Original line number Diff line number Diff line
@@ -125,12 +125,14 @@ int res_counter_charge_nofail(struct res_counter *counter, 
 *

 * these calls check for usage underflow and show a warning on the console

 * _locked call expects the counter->lock to be taken

 *

 * returns the total charges still present in @counter.

 */



void res_counter_uncharge_locked(struct res_counter *counter, unsigned long val);

void res_counter_uncharge(struct res_counter *counter, unsigned long val);

u64 res_counter_uncharge_locked(struct res_counter *counter, unsigned long val);

u64 res_counter_uncharge(struct res_counter *counter, unsigned long val);



void res_counter_uncharge_until(struct res_counter *counter,

u64 res_counter_uncharge_until(struct res_counter *counter,

			       struct res_counter *top,

			       unsigned long val);

/**

kernel/res_counter.c

+13 −7
Original line number Diff line number Diff line
@@ -86,33 +86,39 @@ int res_counter_charge_nofail(struct res_counter *counter, unsigned long val, 
	return __res_counter_charge(counter, val, limit_fail_at, true);

}



void res_counter_uncharge_locked(struct res_counter *counter, unsigned long val)

u64 res_counter_uncharge_locked(struct res_counter *counter, unsigned long val)

{

	if (WARN_ON(counter->usage < val))

		val = counter->usage;



	counter->usage -= val;

	return counter->usage;

}



void res_counter_uncharge_until(struct res_counter *counter,

u64 res_counter_uncharge_until(struct res_counter *counter,

			       struct res_counter *top,

			       unsigned long val)

{

	unsigned long flags;

	struct res_counter *c;

	u64 ret = 0;



	local_irq_save(flags);

	for (c = counter; c != top; c = c->parent) {

		u64 r;

		spin_lock(&c->lock);

		res_counter_uncharge_locked(c, val);

		r = res_counter_uncharge_locked(c, val);

		if (c == counter)

			ret = r;

		spin_unlock(&c->lock);

	}

	local_irq_restore(flags);

	return ret;

}



void res_counter_uncharge(struct res_counter *counter, unsigned long val)

u64 res_counter_uncharge(struct res_counter *counter, unsigned long val)

{

	res_counter_uncharge_until(counter, NULL, val);

	return res_counter_uncharge_until(counter, NULL, val);

}



static inline unsigned long long *

CRA Git | Maintained and supported by SUSTech CRA and CCSE