Commit 50abacbb authored May 19, 2020 by Miquel Raynal

mtd: rawnand: sh_flctl: Stop using nand_release()



This helper is not very useful and very often people get confused:
they use nand_release() instead of nand_cleanup().

Let's stop using nand_release() by calling mtd_device_unregister() and
nand_cleanup() directly.

Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>
Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-48-miquel.raynal@bootlin.com

parent 9748110b

drivers/mtd/nand/raw/sh_flctl.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -1204,9 +1204,13 @@ err_chip:
		static int flctl_remove(struct platform_device *pdev)
		{
		struct sh_flctl *flctl = platform_get_drvdata(pdev);
		struct nand_chip *chip = &flctl->chip;
		int ret;

		flctl_release_dma(flctl);
		nand_release(&flctl->chip);
		ret = mtd_device_unregister(nand_to_mtd(chip));
		WARN_ON(ret);
		nand_cleanup(chip);
		pm_runtime_disable(&pdev->dev);

		return 0;

Admin message