Commit 50ab1a72 authored Sep 20, 2007 by Tejun Heo Committed by Greg Kroah-Hartman Oct 12, 2007

sysfs: kill unnecessary NULL pointer check in sysfs_release()



In sysfs_release(), sysfs_buffer pointed to by filp->private_data is
guaranteed to exist.  Kill the unnecessary NULL check.  This also
makes the code more consistent with the counterpart in fs/sysfs/bin.c.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Acked-by: Cornelia Huck <cornelia.huck@de.ibm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent b05f0548

fs/sysfs/file.c

+4 −5

Original line number	Diff line number	Diff line
		@@ -311,11 +311,10 @@ static int sysfs_release(struct inode * inode, struct file * filp)
		{
		struct sysfs_buffer *buffer = filp->private_data;

		if (buffer) {
		if (buffer->page)
		free_page((unsigned long)buffer->page);
		kfree(buffer);
		}

		return 0;
		}

Admin message