Commit 509d7648 authored Jul 11, 2018 by Magnus Karlsson Committed by Daniel Borkmann Jul 13, 2018

xsk: do not return ENXIO from TX copy mode



This patch removes the ENXIO return code from TX copy-mode when
someone has forcefully changed the number of queues on the device so
that the queue bound to the socket is no longer available. Just
silently stop sending anything as in zero-copy mode so the error
reporting gets consistent between the two modes.

Fixes: 35fcde7f ("xsk: support for Tx")
Signed-off-by: Magnus Karlsson <magnus.karlsson@intel.com>
Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>

parent c7a89784

net/xdp/xsk.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -244,10 +244,8 @@ static int xsk_generic_xmit(struct sock sk, struct msghdr m,
		goto out;
		}

		if (xs->queue_id >= xs->dev->real_num_tx_queues) {
		err = -ENXIO;
		if (xs->queue_id >= xs->dev->real_num_tx_queues)
		goto out;
		}

		skb = sock_alloc_send_skb(sk, len, 1, &err);
		if (unlikely(!skb)) {

Admin message