Commit 5099dea0 authored May 08, 2020 by Wei Yongjun Committed by Jakub Kicinski May 08, 2020

nfp: abm: fix error return code in nfp_abm_vnic_alloc()



Fix to return negative error code -ENOMEM from the kzalloc() error
handling case instead of 0, as done elsewhere in this function.

Fixes: 174ab544 ("nfp: abm: add cls_u32 offload for simple band classification")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Signed-off-by: Jakub Kicinski <kuba@kernel.org>

parent 1f8492df

drivers/net/ethernet/netronome/nfp/abm/main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -333,8 +333,10 @@ nfp_abm_vnic_alloc(struct nfp_app app, struct nfp_net nn, unsigned int id)
		goto err_free_alink;

		alink->prio_map = kzalloc(abm->prio_map_len, GFP_KERNEL);
		if (!alink->prio_map)
		if (!alink->prio_map) {
		err = -ENOMEM;
		goto err_free_alink;
		}

		/* This is a multi-host app, make sure MAC/PHY is up, but don't
		* make the MAC/PHY state follow the state of any of the ports.

Admin message