Commit 507d0ca7 authored Oct 28, 2014 by Michel Dänzer Committed by Alex Deucher Nov 12, 2014

drm/ttm: Use only DRM_MM_SEARCH_BELOW for TTM_PL_FLAG_TOPDOWN



DRM_MM_SEARCH_BEST gets the smallest hole which can fit the BO. That seems
against the idea of TTM_PL_FLAG_TOPDOWN:

* The smallest hole may be in the overall bottom of the area
* If the hole isn't much larger than the BO, it doesn't make much
  difference whether the BO is placed at the bottom or at the top of the
  hole

Reviewed-by: Lauri Kasanen <cand@gmx.com>
Signed-off-by: Michel Dänzer <michel.daenzer@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

parent c165812c

drivers/gpu/drm/ttm/ttm_bo_manager.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -69,7 +69,7 @@ static int ttm_bo_man_get_node(struct ttm_mem_type_manager *man,
		return -ENOMEM;

		if (place->flags & TTM_PL_FLAG_TOPDOWN) {
		sflags \|= DRM_MM_SEARCH_BELOW;
		sflags = DRM_MM_SEARCH_BELOW;
		aflags = DRM_MM_CREATE_TOP;
		}

Admin message