mlxsw: spectrum: Align TC and trap priority (5047d819) · Commits · 戴 / test

The traffic class (TC) attribute of packet traps determines through which TC a packet trap will be scheduled through the CPU port. The priority attribute determines which trap will be triggered in case several packet traps match a packet. We try to configure these attributes to the same value for all packet traps as there is little reason not to. Some packet traps did not use the same value, so rectify that now. Signed-off-by:

Ido Schimmel <idosch@mellanox.com> Reviewed-by:

Jiri Pirko <jiri@mellanox.com> Signed-off-by:

David S. Miller <davem@davemloft.net>

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4253,7 +4253,7 @@ static int mlxsw_sp_trap_groups_set(struct mlxsw_core *mlxsw_core)
		break;
		case MLXSW_REG_HTGT_TRAP_GROUP_SP_LBERROR:
		priority = 0;
		tc = 1;
		tc = 0;
		break;
		case MLXSW_REG_HTGT_TRAP_GROUP_SP_EVENT:
		priority = MLXSW_REG_HTGT_DEFAULT_PRIORITY;

drivers/net/ethernet/mellanox/mlxsw/spectrum_trap.c

+4 −4

Original line number	Diff line number	Diff line
		@@ -207,25 +207,25 @@ static const struct mlxsw_sp_trap_group_item mlxsw_sp_trap_group_items_arr[] = {
		.group = DEVLINK_TRAP_GROUP_GENERIC(L2_DROPS, 1),
		.hw_group_id = MLXSW_REG_HTGT_TRAP_GROUP_SP_L2_DISCARDS,
		.priority = 0,
		.tc = 1,
		.tc = 0,
		},
		{
		.group = DEVLINK_TRAP_GROUP_GENERIC(L3_DROPS, 1),
		.hw_group_id = MLXSW_REG_HTGT_TRAP_GROUP_SP_L3_DISCARDS,
		.priority = 0,
		.tc = 1,
		.tc = 0,
		},
		{
		.group = DEVLINK_TRAP_GROUP_GENERIC(TUNNEL_DROPS, 1),
		.hw_group_id = MLXSW_REG_HTGT_TRAP_GROUP_SP_TUNNEL_DISCARDS,
		.priority = 0,
		.tc = 1,
		.tc = 0,
		},
		{
		.group = DEVLINK_TRAP_GROUP_GENERIC(ACL_DROPS, 1),
		.hw_group_id = MLXSW_REG_HTGT_TRAP_GROUP_SP_ACL_DISCARDS,
		.priority = 0,
		.tc = 1,
		.tc = 0,
		},
		};

Admin message