Commit 504369cd authored Oct 30, 2019 by Linus Walleij

gpiolib: Switch order of valid mask and hw init



The GPIO irqchip needs to initialize the valid mask
before initializing the IRQ hardware, because sometimes
the latter require the former to be executed first.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
Reported-by: Hans de Goede <hdegoede@redhat.com>
Link: https://lore.kernel.org/r/20191030122914.967-1-linus.walleij@linaro.org


Acked-by: Hans de Goede <hdegoede@redhat.com>
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent c1969242

drivers/gpio/gpiolib.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -1411,11 +1411,11 @@ int gpiochip_add_data_with_key(struct gpio_chip chip, void data,

		machine_gpiochip_add(chip);

		ret = gpiochip_irqchip_init_hw(chip);
		ret = gpiochip_irqchip_init_valid_mask(chip);
		if (ret)
		goto err_remove_acpi_chip;

		ret = gpiochip_irqchip_init_valid_mask(chip);
		ret = gpiochip_irqchip_init_hw(chip);
		if (ret)
		goto err_remove_acpi_chip;

Admin message