Commit 50398fde authored Apr 02, 2019 by Anand Jain Committed by David Sterba Apr 04, 2019

btrfs: prop: fix zstd compression parameter validation



We let pass zstd compression parameter even if it is not fully valid.
For example:

  $ btrfs prop set /btrfs compression zst
  $ btrfs prop get /btrfs compression
     compression=zst

zlib and lzo are fine.

Fix it by checking the correct prefix length.

Fixes: 5c1aab1d ("btrfs: Add zstd support")
CC: stable@vger.kernel.org # 4.14+
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Anand Jain <anand.jain@oracle.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent f35f06c3

fs/btrfs/props.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -396,7 +396,7 @@ static int prop_compression_apply(struct inode *inode,
		btrfs_set_fs_incompat(fs_info, COMPRESS_LZO);
		} else if (!strncmp("zlib", value, 4)) {
		type = BTRFS_COMPRESS_ZLIB;
		} else if (!strncmp("zstd", value, len)) {
		} else if (!strncmp("zstd", value, 4)) {
		type = BTRFS_COMPRESS_ZSTD;
		btrfs_set_fs_incompat(fs_info, COMPRESS_ZSTD);
		} else {

Admin message