Commit 5037c628 authored Jun 28, 2018 by Dan Carpenter Committed by David S. Miller Jun 30, 2018

cnic: tidy up a size calculation



Static checkers complain that id_tbl->table points to longs and 4 bytes
is smaller than sizeof(long).  But the since other side is dividing by
32 instead of sizeof(long), that means the current code works fine.

Anyway, it's more conventional to use the BITS_TO_LONGS() macro when
we're allocating a bitmap.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 92291c95

drivers/net/ethernet/broadcom/cnic.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -660,7 +660,7 @@ static int cnic_init_id_tbl(struct cnic_id_tbl *id_tbl, u32 size, u32 start_id,
		id_tbl->max = size;
		id_tbl->next = next;
		spin_lock_init(&id_tbl->lock);
		id_tbl->table = kcalloc(DIV_ROUND_UP(size, 32), 4, GFP_KERNEL);
		id_tbl->table = kcalloc(BITS_TO_LONGS(size), sizeof(long), GFP_KERNEL);
		if (!id_tbl->table)
		return -ENOMEM;

Admin message