Commit 503330f3 authored by Jan Kara's avatar Jan Kara
Browse files

quota: Remove dq_wait_unused from dquot 



Currently every dquot carries a wait_queue_head_t used only when we are
turning quotas off to wait for last users to drop dquot references.
Since such rare case is not performance sensitive in any means, just use
a global waitqueue for this and save space in struct dquot. Also convert
the logic to use wait_event() instead of open-coding it.

Signed-off-by: default avatarJan Kara <jack@suse.cz>
parent 1e0b7cb0

fs/quota/dquot.c

+7 −10
Original line number Diff line number Diff line
@@ -126,6 +126,8 @@ __cacheline_aligned_in_smp DEFINE_SPINLOCK(dq_data_lock); 
EXPORT_SYMBOL(dq_data_lock);

DEFINE_STATIC_SRCU(dquot_srcu);



static DECLARE_WAIT_QUEUE_HEAD(dquot_ref_wq);



void __quota_error(struct super_block *sb, const char *func,

		   const char *fmt, ...)

{
@@ -527,22 +529,18 @@ restart: 
			continue;

		/* Wait for dquot users */

		if (atomic_read(&dquot->dq_count)) {

			DEFINE_WAIT(wait);



			dqgrab(dquot);

			prepare_to_wait(&dquot->dq_wait_unused, &wait,

					TASK_UNINTERRUPTIBLE);

			spin_unlock(&dq_list_lock);

			/* Once dqput() wakes us up, we know it's time to free

			/*

			 * Once dqput() wakes us up, we know it's time to free

			 * the dquot.

			 * IMPORTANT: we rely on the fact that there is always

			 * at most one process waiting for dquot to free.

			 * Otherwise dq_count would be > 1 and we would never

			 * wake up.

			 */

			if (atomic_read(&dquot->dq_count) > 1)

				schedule();

			finish_wait(&dquot->dq_wait_unused, &wait);

			wait_event(dquot_ref_wq,

				   atomic_read(&dquot->dq_count) == 1);

			dqput(dquot);

			/* At this moment dquot() need not exist (it could be

			 * reclaimed by prune_dqcache(). Hence we must
@@ -754,7 +752,7 @@ we_slept: 
		/* Releasing dquot during quotaoff phase? */

		if (!sb_has_quota_active(dquot->dq_sb, dquot->dq_id.type) &&

		    atomic_read(&dquot->dq_count) == 1)

			wake_up(&dquot->dq_wait_unused);

			wake_up(&dquot_ref_wq);

		spin_unlock(&dq_list_lock);

		return;

	}
@@ -809,7 +807,6 @@ static struct dquot *get_empty_dquot(struct super_block *sb, int type) 
	INIT_LIST_HEAD(&dquot->dq_inuse);

	INIT_HLIST_NODE(&dquot->dq_hash);

	INIT_LIST_HEAD(&dquot->dq_dirty);

	init_waitqueue_head(&dquot->dq_wait_unused);

	dquot->dq_sb = sb;

	dquot->dq_id = make_kqid_invalid(type);

	atomic_set(&dquot->dq_count, 1);

include/linux/quota.h

+0 −1
Original line number Diff line number Diff line
@@ -299,7 +299,6 @@ struct dquot { 
	struct list_head dq_dirty;	/* List of dirty dquots */

	struct mutex dq_lock;		/* dquot IO lock */

	atomic_t dq_count;		/* Use count */

	wait_queue_head_t dq_wait_unused;	/* Wait queue for dquot to become unused */

	struct super_block *dq_sb;	/* superblock this applies to */

	struct kqid dq_id;		/* ID this applies to (uid, gid, projid) */

	loff_t dq_off;			/* Offset of dquot on disk */

CRA Git | Maintained and supported by SUSTech CRA and CCSE