Commit 5030fcbf authored by Linus Torvalds's avatar Linus Torvalds
Browse files

Merge git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac 

Pull EDAC fixes from Mauro Carvalho Chehab:
 "Three edac fixes at the memory enumeration logic:
        - i3200_edac: Fixes a regression at the memory rank size, when the
                memorias are dual-rank;
        - i5000_edac: Fix a longstanding bug when calculating the memory
                size: before Kernel 3.6, the memory size were right only
                with one specific configuration;
        - sb_edac: Fixes a bug since the initial release of the driver:
                with 16GB DIMMs, there's an overflow at the memory size,
                causing the number of pages per dimm (an unsigned value)
                to have the highest bit equal to 1, effectively mangling
                the memory size.

  The third bug can potentially affect the error decoding logic as well."

* git://git.kernel.org/pub/scm/linux/kernel/git/mchehab/linux-edac:
  sb_edac: Avoid overflow errors at memory size calculation
  i5000: Fix the memory size calculation with 2R memories
  i3200_edac: Fix memory rank size
parents fd517909 deb09dda

drivers/edac/i3200_edac.c

+1 −1
Original line number Diff line number Diff line
@@ -391,7 +391,7 @@ static int i3200_probe1(struct pci_dev *pdev, int dev_idx) 
		for (j = 0; j < nr_channels; j++) {

			struct dimm_info *dimm = csrow->channels[j]->dimm;



			dimm->nr_pages = nr_pages / nr_channels;

			dimm->nr_pages = nr_pages;

			dimm->grain = nr_pages << PAGE_SHIFT;

			dimm->mtype = MEM_DDR2;

			dimm->dtype = DEV_UNKNOWN;

drivers/edac/i5000_edac.c

+4 −0
Original line number Diff line number Diff line
@@ -1012,6 +1012,10 @@ static void handle_channel(struct i5000_pvt *pvt, int slot, int channel, 
			/* add the number of COLUMN bits */

			addrBits += MTR_DIMM_COLS_ADDR_BITS(mtr);



			/* Dual-rank memories have twice the size */

			if (dinfo->dual_rank)

				addrBits++;



			addrBits += 6;	/* add 64 bits per DIMM */

			addrBits -= 20;	/* divide by 2^^20 */

			addrBits -= 3;	/* 8 bits per bytes */

drivers/edac/sb_edac.c

+4 −3
Original line number Diff line number Diff line
@@ -513,7 +513,8 @@ static int get_dimm_config(struct mem_ctl_info *mci) 
{

	struct sbridge_pvt *pvt = mci->pvt_info;

	struct dimm_info *dimm;

	int i, j, banks, ranks, rows, cols, size, npages;

	unsigned i, j, banks, ranks, rows, cols, npages;

	u64 size;

	u32 reg;

	enum edac_type mode;

	enum mem_type mtype;
@@ -585,10 +586,10 @@ static int get_dimm_config(struct mem_ctl_info *mci) 
				cols = numcol(mtr);



				/* DDR3 has 8 I/O banks */

				size = (rows * cols * banks * ranks) >> (20 - 3);

				size = ((u64)rows * cols * banks * ranks) >> (20 - 3);

				npages = MiB_TO_PAGES(size);



				edac_dbg(0, "mc#%d: channel %d, dimm %d, %d Mb (%d pages) bank: %d, rank: %d, row: %#x, col: %#x\n",

				edac_dbg(0, "mc#%d: channel %d, dimm %d, %Ld Mb (%d pages) bank: %d, rank: %d, row: %#x, col: %#x\n",

					 pvt->sbridge_dev->mc, i, j,

					 size, npages,

					 banks, ranks, rows, cols);

CRA Git | Maintained and supported by SUSTech CRA and CCSE