Commit 502fcb79 authored Jul 30, 2011 by Mathias Krause Committed by Greg Kroah-Hartman Aug 23, 2011

tty: clearify structure initializer in notify_write()



Even though this is valid C we should not mix C99 initializers with
obfuscated ANSI C. Stick to C99 and initialize c by its name.

Found by clang:
drivers/tty/vt/vt.c:262:55: warning: explicitly assigning a variable of
type 'unsigned int' to itself [-Wself-assign]
    struct vt_notifier_param param = { .vc = vc, unicode = unicode };
                                                 ~~~~~~~ ^ ~~~~~~~

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

parent 0c6967b5

drivers/tty/vt/vt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -259,7 +259,7 @@ EXPORT_SYMBOL_GPL(unregister_vt_notifier);

		static void notify_write(struct vc_data *vc, unsigned int unicode)
		{
		struct vt_notifier_param param = { .vc = vc, unicode = unicode };
		struct vt_notifier_param param = { .vc = vc, .c = unicode };
		atomic_notifier_call_chain(&vt_notifier_list, VT_WRITE, &param);
		}

Admin message