Commit 502f159c authored Jun 03, 2015 by David Gibson Committed by Michael Ellerman Jun 07, 2015

powerpc/eeh: Fix trivial error in eeh_restore_dev_state()



Commit 28158cd1 "powerpc/eeh: Enhance pcibios_set_pcie_reset_state()"
introduced a fix for a problem where certain configurations could lead to
pci_reset_function() destroying the state of PCI devices other than the one
specified.

Unfortunately, the fix has a trivial bug - it calls pci_save_state() again,
when it should be calling pci_restore_state().  This corrects the problem.

Cc: Gavin Shan <gwshan@au1.ibm.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
Acked-by: Gavin Shan <gwshan@linux.vnet.ibm.com>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>

parent 0d7cd855

arch/powerpc/kernel/eeh.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -717,7 +717,7 @@ static void eeh_restore_dev_state(void data, void *userdata)

		/* The caller should restore state for the specified device */
		if (pdev != dev)
		pci_save_state(pdev);
		pci_restore_state(pdev);

		return NULL;
		}

Admin message